Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploy_build_before example hook for theme assets #397

Merged
merged 1 commit into from
Nov 1, 2015

Conversation

retlehs
Copy link
Member

@retlehs retlehs commented Oct 26, 2015

not everyone using trellis is going to have a theme that needs this, but i would still like this to exist as a placeholder.

see https://discourse.roots.io/t/deployment-with-the-new-trellis-hooks/5016/2?u=benword

@retlehs
Copy link
Member Author

retlehs commented Oct 26, 2015

another benefit is that this also provides an example of how to use a deploy hook along with where to put it

# chdir: "{{ project.local_path }}/web/app/themes/sage"
# - name: Copy project local files
# synchronize: src="{{ item.src }}"
# dest="{{ deploy_helper.new_release_path }}/{{ item.dest }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to use new syntax here

@fullyint
Copy link
Contributor

Could this PR also remove the the existing "Copy project local files" task and the corresponding project_local_files default variable? They seem obsolete now that this PR's "Copy project local files" task demonstrates the new recommended approach of using deploy hooks.

@swalkinshaw
Copy link
Member

@fullyint good catch! Definitely need to remove those.

swalkinshaw added a commit that referenced this pull request Nov 1, 2015
Add deploy_build_before example hook for theme assets
@swalkinshaw swalkinshaw merged commit b6a6c96 into master Nov 1, 2015
@swalkinshaw swalkinshaw deleted the build-before-placeholder branch November 1, 2015 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants